Make calls on cacheArtifacts/reconnect/submit/canel non-blocking #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andyz26
requested review from
nickmahilani,
jeffchao,
piygoyal,
calvin681,
sundargates,
hmitnflx,
markcho,
liuml07 and
fdc-ntflx
as code owners
Andyz26
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
fdc-ntflx
reviewed
Sep 14, 2023
| @@ -259,6 +259,13 @@ protected TaskExecutorGateway getGateway() throws ExecutionException, Interrupte | |||
| return this.gateway.get(); | |||
| } | |||
|
|
|||
| protected CompletableFuture<TaskExecutorGateway> getGatewayAsync() { | |||
sundargates
approved these changes
Sep 14, 2023
| @@ -118,7 +118,7 @@ CompletableFuture<TaskExecutorID> getTaskExecutorFor( | |||
| */ | |||
| CompletableFuture<TaskExecutorGateway> getTaskExecutorGateway(TaskExecutorID taskExecutorID); | |||
|
|
|||
| CompletableFuture<TaskExecutorGateway> reconnectTaskExecutorGateway(TaskExecutorID taskExecutorID); | |||
| CompletableFuture<Ack> reconnectTaskExecutorGateway(TaskExecutorID taskExecutorID); | |||
There was a problem hiding this comment.
nit: s/reconnect.*Gateway/reconnect
| @@ -259,6 +259,13 @@ protected TaskExecutorGateway getGateway() throws ExecutionException, Interrupte | |||
| return this.gateway.get(); | |||
| } | |||
|
|
|||
| protected CompletableFuture<TaskExecutorGateway> getGatewayAsync() { | |||
There was a problem hiding this comment.
nit: no need to explicitly call this method async since the type already reflects that.
There was a problem hiding this comment.
Also, get rid of the blocking method.
Andyz26
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Andyz26
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Andyz26
changed the title
sundargates
reviewed
Sep 14, 2023
| @@ -112,6 +115,8 @@ public Receive createReceive() { | |||
| .match(FailedToSubmitScheduleRequestEvent.class, this::onFailedToSubmitScheduleRequestEvent) | |||
| .match(RetryCancelRequestEvent.class, this::onRetryCancelRequestEvent) | |||
| .match(Noop.class, this::onNoop) | |||
| .match(Ack.class, ack -> log.debug("Received ack from {}", sender())) | |||
| .match(Failure.class, failure -> log.error("Received failure from {}: {}", sender(), failure)) | |||
There was a problem hiding this comment.
When is this message sent?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Convert the get resourceGateway calls (which perform RPC connection inside) to return future and perform the actions on the future's completion instead of blocking and waiting.
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests